Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desk Height #95

Open
wernerhp opened this issue Sep 30, 2024 · 4 comments
Open

Desk Height #95

wernerhp opened this issue Sep 30, 2024 · 4 comments

Comments

@wernerhp
Copy link

The desk height component has some glitches.

When setting the height from 72.5cm to 105cm it starts but then stops shortly after with with a height value of 800cm (I suspect this hsould be 80.0cm).
Similarly, when it lowers from 105cm to 72.5, it stops shortly after with a height value of 10cm (I suspect this should be 100.0cm)

image image image
Screen.Recording.2024-09-30.at.12.05.33.mov
@iMicknl
Copy link
Owner

iMicknl commented Oct 18, 2024

Which version do you use? We just published a new version of this component, see the README.

Number entity will still overshoot, but in general the code is better.

@wernerhp
Copy link
Author

I tried main and v2

source: github://iMicknl/LoctekMotion_IoT@v2
  components: [ loctekmotion_desk_height ]

@wernerhp
Copy link
Author

wernerhp commented Oct 18, 2024

Screenshot_20241018-190954

I'd have expected the cponent to be updated. That's where the problem appeared to have been.

The hex_to_int func doesn't output the correct value for all decimal values from what I could tell.

@iMicknl
Copy link
Owner

iMicknl commented Oct 18, 2024

@wernerhp I would need to investigate if I face the same issue, or if your device is different..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants