-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SiD_o2_v04 beampipe constants to global list. #253
Conversation
This fixes an error in the key4hep builds: ``` XercesC FATAL +++ FATAL Error at file "/tmp/gitlab-runner/spack-stage/spack-stage-lcgeo-commit.032c4cc7bc8ed6be1071e931dccf904fb7976b8a-2javekkqt44e34d47dhiva3wh3srpqor/spack-src/SiD/compact/SiD_o2_v04/BeamPipe_o2_v04.xml", Line 4 Column: 1 Message:comment or processing instruction expected ``` Most likely due to a newer version of dd4hep used there not available in the lcgeo CI.
Please add which detector this change belongs to to the Release Notes |
Done! And yes, it's not the most helpful error message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with moving the SiD_o2_v04 beam pipe constants to the main XML
@vvolkl The geant4 data files are not available in the key4hep setup |
@andresailer The key4hep setup is ok, but the spack-installed EDIT: no, the geant4-data seems to be at fault, it shouldn't be empty, but symlink to the individual datasets. |
The geant data files on cvmfs should be fixed. Closing and re-opening to trigger CI. |
This fixes an error in the key4hep builds:
Most likely due to a newer version of dd4hep used there not available in the lcgeo CI.
EDIT: The error is tied to Xerces-C being used by DD4hep, which is not the case for the iLCSoft nightlies.
BEGINRELEASENOTES
ENDRELEASENOTES