Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SiD_o2_v04 beampipe constants to global list. #253

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

vvolkl
Copy link
Contributor

@vvolkl vvolkl commented Jun 13, 2022

This fixes an error in the key4hep builds:

XercesC FATAL +++ FATAL Error at file 
"/tmp/gitlab-runner/spack-stage/spack-stage-lcgeo-commit.032c4cc7bc8ed6be1071e931dccf904fb7976b8a-2javekkqt44e34d47dhiva3wh3srpqor/spack-src/SiD/compact/SiD_o2_v04/BeamPipe_o2_v04.xml", Line 4 Column: 1 
Message:comment or processing instruction expected

Most likely due to a newer version of dd4hep used there not available in the lcgeo CI.

EDIT: The error is tied to Xerces-C being used by DD4hep, which is not the case for the iLCSoft nightlies.

BEGINRELEASENOTES

  • Move SiD_o2_v04 beampipe constants to global list to fix an error in key4hep builds

ENDRELEASENOTES

This fixes an error in the key4hep builds:

```
XercesC FATAL +++ FATAL Error at file "/tmp/gitlab-runner/spack-stage/spack-stage-lcgeo-commit.032c4cc7bc8ed6be1071e931dccf904fb7976b8a-2javekkqt44e34d47dhiva3wh3srpqor/spack-src/SiD/compact/SiD_o2_v04/BeamPipe_o2_v04.xml", Line 4 Column: 1 Message:comment or processing instruction expected
```

Most likely due to a newer version of dd4hep used there not available in the lcgeo CI.
@andresailer
Copy link
Contributor

Please add which detector this change belongs to to the Release Notes
Also a bit puzzling why the error is about Line 4.

@vvolkl
Copy link
Contributor Author

vvolkl commented Jun 13, 2022

Done!

And yes, it's not the most helpful error message.

@vvolkl vvolkl changed the title Move beampipe constants to global list. Move SiD_o2_v04 beampipe constants to global list. Jun 13, 2022
Copy link
Contributor

@protopopescu protopopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with moving the SiD_o2_v04 beam pipe constants to the main XML

@andresailer
Copy link
Contributor

@vvolkl The geant4 data files are not available in the key4hep setup

@vvolkl
Copy link
Contributor Author

vvolkl commented Jun 13, 2022

@andresailer The key4hep setup is ok, but the spack-installed ${G4INSTALL}/bin/geant4.sh is not. It sets the directory for all datafiles to the (empty) install prefix of the geant4-data bundle package. I'll try to fix this.

EDIT: no, the geant4-data seems to be at fault, it shouldn't be empty, but symlink to the individual datasets.

@vvolkl
Copy link
Contributor Author

vvolkl commented Jun 14, 2022

The geant data files on cvmfs should be fixed. Closing and re-opening to trigger CI.

@vvolkl vvolkl closed this Jun 14, 2022
@vvolkl vvolkl reopened this Jun 14, 2022
@andresailer andresailer merged commit abde1f0 into key4hep:master Jun 14, 2022
@vvolkl vvolkl deleted the fix-xml branch June 14, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants