Fix query string bugs relating to repeated elements #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jon-betts
commented
Jan 29, 2020
jon-betts
commented
- Also separate out testing of the component
- Remove duplicated testing in other places
- Use the same code more times
- Rather than inventing a new way at the end of get_content_type()
jon-betts
commented
Jan 29, 2020
| ( | ||
| "/https://example.com/foo?via.open_sidebar=1", | ||
| "http://via.hypothes.is/https://example.com/foo?via.open_sidebar=1", | ||
| "text/html", |
There was a problem hiding this comment.
All of these tests amount to the same thing, and are replicated lower down. We always pass all params onto the final request. It only changes when we call the original URL to check the resource content type.
jon-betts
commented
Jan 29, 2020
jon-betts
commented
Jan 29, 2020
| "h_open_sidebar": asbool(request.params.get(OPEN_SIDEBAR, False)), | ||
| "h_request_config": request.params.get(CONFIG_FROM_FRAME, None), | ||
| "h_open_sidebar": asbool(request.params.get(QueryParams.OPEN_SIDEBAR, False)), | ||
| "h_request_config": request.params.get(QueryParams.CONFIG_FROM_FRAME, None), |
There was a problem hiding this comment.
This bit of processing could be moved to QueryParams, but then:
- This code wouldn't have anything to do and would get sad
- The code wouldn't get any shorter as we'd have to unpack whatever we were sent
jon-betts
commented
Jan 29, 2020
seanh
approved these changes
Jan 30, 2020
| return exc.HTTPFound(f"{via_url}/{url}", headers=headers) | ||
| return exc.HTTPFound( | ||
| QueryParams.build_url( | ||
| f"{via_url}/{path_url}", request.params, strip_via_params=False |
There was a problem hiding this comment.
Suggested change
| f"{via_url}/{path_url}", request.params, strip_via_params=False | |
| f"{via_url}/{path_url}", request.params |
It defaults to False
There was a problem hiding this comment.
Yeah, I think I might remove the default to force you to say. This was to make crystal clear the intent.
* Also separate out testing of the component * Remove duplicated testing in other places * Use the same code more times * Rather than inventing a new way at the end of get_content_type()
jon-betts
force-pushed
the
query-params-improvements
branch
from
edd94af to
487966c
Compare
jon-betts
changed the title
|
So after some more research it turns out that the query parameters are case sensitive. I've changed the PR to reflect that and the review points above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.