From 2a23886dbda1f286080dbf7b22d833d248dc56d7 Mon Sep 17 00:00:00 2001
From: torusrxxx <torusrxxx@users.noreply.github.com>
Date: Sat, 28 Dec 2024 12:45:28 +0800
Subject: [PATCH] Fix NullPointerException when disabling and reenabling SSL

---
 src/freenet/clients/http/ToadletContextImpl.java |  5 -----
 src/freenet/crypt/SSL.java                       | 12 ++++++++++--
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/freenet/clients/http/ToadletContextImpl.java b/src/freenet/clients/http/ToadletContextImpl.java
index 9a6ba9fb82..e269b79ab2 100644
--- a/src/freenet/clients/http/ToadletContextImpl.java
+++ b/src/freenet/clients/http/ToadletContextImpl.java
@@ -440,11 +440,6 @@ static void sendReplyHeaders(
 		mvt.put("x-content-security-policy", contentSecurityPolicy);
 		mvt.put("x-webkit-csp", contentSecurityPolicy);
 		mvt.put("x-frame-options", allowFrames ? "SAMEORIGIN" : "DENY");
-		String HSTS = SSL.getHSTSHeader();
-		if(!HSTS.isEmpty() && !mvt.containsKey("strict-transport-security")) {
-			// SSL enabled, set strict-transport-security so that the user agent upgrade future requests to SSL.
-			mvt.put("strict-transport-security", HSTS);
-		}
 		StringBuilder buf = new StringBuilder(1024);
 		buf.append("HTTP/1.1 ");
 		buf.append(replyCode);
diff --git a/src/freenet/crypt/SSL.java b/src/freenet/crypt/SSL.java
index 36fbfae9c1..effa52ae3b 100644
--- a/src/freenet/crypt/SSL.java
+++ b/src/freenet/crypt/SSL.java
@@ -86,7 +86,7 @@ public static boolean available() {
 	}
 
 	public static String getHSTSHeader() {
-		if(available() && HSTSMaxAge > 0)
+		if(enable && available() && HSTSMaxAge > 0)
 			return "max-age=" + HSTSMaxAge;
 		else
 			return "";
@@ -119,11 +119,16 @@ public void set(Boolean newValue) throws InvalidConfigValueException {
 							} catch(Exception e) {
 								enable = false;
 								e.printStackTrace(System.out);
+								Logger.error(this, "SSL could not be enabled", e);
 								throwConfigError("SSL could not be enabled", e);
 							}
 						else {
 							ssf = null;
-							keyStore = null;
+							try {
+								keystore.load(null, keyStorePass.toCharArray());
+							} catch (Exception e) {
+								// Just clear the key store
+							}
 						}
 					}
 				}
@@ -147,6 +152,7 @@ public void set(String newKeyStore) throws InvalidConfigValueException {
 						} catch(Exception e) {
 							keyStore = oldKeyStore;
 							e.printStackTrace(System.out);
+							Logger.error(this, "Keystore file could not be changed", e);
 							throwConfigError("Keystore file could not be changed", e);
 						}
 					}
@@ -171,6 +177,7 @@ public void set(String newKeyStorePass) throws InvalidConfigValueException {
 						} catch(Exception e) {
 							keyStorePass = oldKeyStorePass;
 							e.printStackTrace(System.out);
+							Logger.error(this, "Keystore password could not be changed", e);
 							throwConfigError("Keystore password could not be changed", e);
 						}
 					}
@@ -198,6 +205,7 @@ public void set(String newKeyPass) throws InvalidConfigValueException {
 						} catch(Exception e) {
 							keyPass = oldKeyPass;
 							e.printStackTrace(System.out);
+							Logger.error(this, "Private key password could not be changed", e);
 							throwConfigError("Private key password could not be changed", e);
 						}
 					}