Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add log mechanism #89

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Feat: add log mechanism #89

merged 1 commit into from
Apr 7, 2021

Conversation

heming6666
Copy link
Contributor

Purpose

  • add log mechanism to make it easier to debug.
  • catch errors and show the notice to users when something goes wrong.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

@LiuChangFreeman LiuChangFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LiuChangFreeman
Copy link
Contributor

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Apr 7, 2021
Signed-off-by: LinHaiming <lhming23@outlook.com>
@menbotics menbotics bot merged commit 3a49b74 into hypertrons:master Apr 7, 2021
LiuChangFreeman pushed a commit to LiuChangFreeman/hypertrons-crx that referenced this pull request Apr 7, 2021
Signed-off-by: LinHaiming <lhming23@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants