refactor: remove dependency on iroha_wasm_builder from iroha cli and client #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
dima74
as code owners
mversic
reviewed
Jul 25, 2024
mversic
approved these changes
Jul 25, 2024
nxsaken
approved these changes
Jul 26, 2024
…client This moves the `construct_executor` utility function from `iroha_cli` to `test_network`, as it only gets used in tests Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
nxsaken
force-pushed
the
remove-iroha-wasm-builder-deps
branch
from
7edaafa to
698380b
Compare
mversic
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had some unnecessary dependencies on
iroha_wasm_builder, blocking the build of iroha cli and client. This PR removes those and makes it so only theiroha_wasm_buildercli and integration tests actually depend on the crate.As a part of this change,
construct_executorutility function is moved fromiroha_clitotest_network, as it only gets used in tests. Not entirely happy with its new location, butiroha_cliis definitely a worse place for this.Linked issue
Closes #4882
Benefits
Hopefully, faster incremental builds in cases when integration tests are not being built.
Checklist
CONTRIBUTING.md