-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename configs
to defaults
, remove swarm
#4862
Merged
nxsaken
merged 2 commits into
hyperledger:main
from
nxsaken:refactor/configs-to-defaults
Jul 29, 2024
Merged
refactor: rename configs
to defaults
, remove swarm
#4862
nxsaken
merged 2 commits into
hyperledger:main
from
nxsaken:refactor/configs-to-defaults
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was renamed for the 5th time already. We have to agree on this for once |
eb5189a
to
e002f4f
Compare
0x009922
reviewed
Jul 23, 2024
e002f4f
to
19adc37
Compare
0x009922
previously approved these changes
Jul 24, 2024
19adc37
to
ec6a968
Compare
mversic
reviewed
Jul 26, 2024
mversic
previously approved these changes
Jul 26, 2024
ec6a968
to
72d22e0
Compare
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
72d22e0
to
4391d5b
Compare
mversic
approved these changes
Jul 26, 2024
0x009922
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename the
configs
directory todefaults
since that's what it really is (default docker compose configs, defaultexecutor.wasm
, defaultgenesis.json
, etc.)Linked issue
Closes #4293, #4320
Benefits
Conveys the purpose of the directory better.
Checklist
CONTRIBUTING.md