refactor: rename configs to defaults, remove swarm
#4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxsaken
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
|
This was renamed for the 5th time already. We have to agree on this for once |
nxsaken
force-pushed
the
refactor/configs-to-defaults
branch
2 times, most recently
from
eb5189a
to
e002f4f
Compare
0x009922
reviewed
Jul 23, 2024
nxsaken
force-pushed
the
refactor/configs-to-defaults
branch
from
e002f4f
to
19adc37
Compare
0x009922
previously approved these changes
Jul 24, 2024
nxsaken
force-pushed
the
refactor/configs-to-defaults
branch
from
19adc37
to
ec6a968
Compare
mversic
reviewed
Jul 26, 2024
mversic
previously approved these changes
Jul 26, 2024
mversic
force-pushed
the
refactor/configs-to-defaults
branch
from
ec6a968
to
72d22e0
Compare
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken
force-pushed
the
refactor/configs-to-defaults
branch
from
72d22e0
to
4391d5b
Compare
mversic
approved these changes
Jul 26, 2024
0x009922
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename the
configsdirectory todefaultssince that's what it really is (default docker compose configs, defaultexecutor.wasm, defaultgenesis.json, etc.)Linked issue
Closes #4293, #4320
Benefits
Conveys the purpose of the directory better.
Checklist
CONTRIBUTING.md