Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest tag in Docker image workflows #1506

Open
nguyer opened this issue Apr 26, 2024 · 1 comment · May be fixed by #1566
Open

Fix latest tag in Docker image workflows #1506

nguyer opened this issue Apr 26, 2024 · 1 comment · May be fixed by #1566
Assignees

Comments

@nguyer
Copy link
Contributor

nguyer commented Apr 26, 2024

Right now our docker image GitHub workflows have a problem where if we release a 1.2.x patch release after a 1.3.0, the 1.2.x release will get tagged as latest which will potentially "downgrade" people if they try to pull latest. I think most people would expect 1.3.0 to remain the latest in this case.

I wrote a new way of determining whether a workflow is running as the result of being the latest release, or just some other release and it's part of the docs site build here: https://github.com/hyperledger/firefly/blob/main/.github/workflows/docs.yml#L26-L48

We should port this code into the docker release job as well: https://github.com/hyperledger/firefly/blob/main/.github/workflows/docker_release.yml

This definitely needs to happen before we do a 1.2.3 patch release or we will need to manually fix Docker tags as we have in the past.

@dwertent
Copy link
Contributor

I will consider a straightforward approach to handle git tags, perhaps:

      - name: Retrieve all tags
        run: |
          git fetch --tags

      - name: Identify the latest tag
        id: get_latest_tag
        run: |
          latest_tag=$(git tag -l | sort -V | tail -n 1)
          echo "latest_tag=${latest_tag}" >> $GITHUB_ENV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants