Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-aws-sm): complete request handler and endpoints #967

Closed
jagpreetsinghsasan opened this issue May 17, 2021 · 4 comments
Closed

feat(keychain-aws-sm): complete request handler and endpoints #967

jagpreetsinghsasan opened this issue May 17, 2021 · 4 comments
Assignees
@Leeyoungone
Labels
enhancement New feature or request good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented May 17, 2021 •
edited
Loading

Description

As a developer, I want to complete the code to enable the endpoints
get-keychain-entry
set-keychain-entry
delete-keychain-entry (or maybe use set-keychain-entry with tags for deletion)
Also, write tests that use the API client instead of the plugin instance directly.

Acceptance Criteria

  1. Update openapi.json at packages/cactus-plugin-keychain-aws-sm/src/main/json/openapi.json
  2. Update the endpoints at packages/cactus-plugin-keychain-aws-sm/src/main/typescript/webservices
  3. Update the remote adapter code at packages/cactus-plugin-keychain-aws-sm/src/main/typescript/plugin-keychain-aws-sm-remote-adapter.ts
  4. Update the test code at packages/cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @petermetz @TonyRowntree @travis-payne
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue May 17, 2021
Merged
@petermetz petermetz changed the title feat(aws-sm): complete request handler and endpoints feat(keychain-aws-sm): complete request handler and endpoints May 17, 2021
@petermetz petermetz added enhancement New feature or request Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. labels May 17, 2021
@petermetz
Copy link
Contributor

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

@Leeyoungone
Copy link
Contributor

I'll work on this ! @petermetz

@decommissioned-account
Copy link

@petermetz Same issue as #1010 - the keychain-aws-sm package doesn't exist

@petermetz
Copy link
Contributor

@petermetz Same issue as #1010 - the keychain-aws-sm package doesn't exist

@ty-lazar @Leeyoungone Please base the feature branch off of Jagpreet's branch (there's an open PR with it)

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
ba811ef 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
47d8dd1 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 26, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
0d03e46 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 26, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
4f99fc3 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 26, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
455b47d 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 28, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
e320827 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jul 28, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
43deb18 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 3, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
7bc76e8 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 4, 2021
@Leeyoungone
refactor: add plugin factory keychain test file
9fde86c 
Fixes hyperledger-cacti#967
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 4, 2021
@Leeyoungone
refactor: add plugin factory keychain test file
3d4a475 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 4, 2021
@Leeyoungone
refactor: add plugin factory keychain test file
816f072 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 5, 2021
@Leeyoungone
refactor: add plugin factory keychain test file
45d721e 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 6, 2021
@Leeyoungone
refactor: add plugin factory keychain test file
9b5af88 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 9, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
883945c 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 16, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
d30a731 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 17, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
28bb2e4 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
8570aab 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
b8d7d62 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
040c0bc 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 29, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
8ddde96 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 1, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
bafa6f8 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 1, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
bc3a8ad 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 1, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
48200e9 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 2, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
0b6a785 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 15, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
13625c7 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 16, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
54b34bf 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
76988ed 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
5fa0342 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
fd28b83 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
1ea7775 
Fixes hyperledger-cacti#967

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Sep 22, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
56de06b 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Oct 1, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
76b0f54 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Oct 1, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
62556b6 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Oct 4, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
f031d2e 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Oct 4, 2021
@Leeyoungone
feat(keychain-aws-sm): complete request handler and endpoint
51baf5e 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit to Leeyoungone/cactus that referenced this issue Oct 6, 2021
@Leeyoungone @petermetz
feat(keychain-aws-sm): complete request handler and endpoint
2ada34f 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@Leeyoungone @RafaelAPB
feat(keychain-aws-sm): complete request handler and endpoint
8d5ed90 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leeyoungone Leeyoungone

Labels
enhancement New feature or request good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petermetz @jagpreetsinghsasan @Leeyoungone @decommissioned-account