fix(api-client): flaky DefaultConsortiumProvider test #605
Labels
bug
Something isn't working
good-first-issue
Good for newcomers
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Describe the bug
There's this one test that I've seen the second time failing now (and it's a fluke with a timeout).
To Reproduce
It's random so no repro steps.
Expected behavior
Tests should be consistent.
Logs/Stack traces
https://github.com/hyperledger/cactus/pull/602/checks?check_run_id=1985681878#step:10:27
Screenshots
N/A
Cloud provider or hardware configuration:
GitHub Action Execution environment. Never seen it on my dev machines.
Operating system name, version, build:
See the ci.yml file for the OS details.
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
main
Hyperledger Cactus Plugins/Connectors Used
The manual consortium management plugin.
Additional context
There is a test that uses a timeout to assert whether something was successful or not. Currently this timeout is a 100ms which appears to be too low nowadays (could indicate that our GH actions are getting less CPU power than before?).
Likely just a matter of bumping up the timeout to 10x or 100x the current value, but would be nice if the need for the timeout could be completely eliminated (while preserving the test case and the assertions themselves of course).
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
The text was updated successfully, but these errors were encountered: