Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): Servers#startOnPort() error handling #317

Closed
petermetz opened this issue Oct 15, 2020 · 0 comments
Closed

fix(common): Servers#startOnPort() error handling #317

petermetz opened this issue Oct 15, 2020 · 0 comments
Assignees
@petermetz
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@petermetz
Copy link
Contributor

Describe the bug

If the NodeJS HTTP server error object emits an error event, the promise is not rejected as it should be.

To Reproduce

Invoke Servers.startOnPort() in a way that will make the server listen call fail and then see the promise hang forever.

Expected behavior

It should have the returned promise reject instead of hanging.

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

v0.1.0
@petermetz petermetz added the bug Something isn't working label Oct 15, 2020
@petermetz petermetz added this to the v2.0.0 milestone Oct 15, 2020
@petermetz petermetz self-assigned this Oct 15, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Oct 15, 2020
@petermetz
fix(common): servers.startOnPort() error handling
ac77099 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 17, 2020
@petermetz
fix(common): servers.startOnPort() error handling
bc856a8 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 19, 2020
@petermetz
fix(common): servers.startOnPort() error handling
e196cf4 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 19, 2020
@petermetz
fix(common): servers.startOnPort() error handling
4f24370 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 19, 2020
@petermetz
fix(common): servers.startOnPort() error handling
558af35 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 20, 2020
@petermetz
fix(common): servers.startOnPort() error handling
09e844a 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 22, 2020
@petermetz
fix(common): servers.startOnPort() error handling
ad24fd7 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 26, 2020
@petermetz
fix(common): servers.startOnPort() error handling
b160712 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 27, 2020
@petermetz
fix(common): servers.startOnPort() error handling
dd5aa00 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 27, 2020
@petermetz
fix(common): servers.startOnPort() error handling
934c2c2 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz modified the milestones: v2.0.0, v0.2.0 Oct 29, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Nov 2, 2020
@petermetz
fix(common): servers.startOnPort() error handling
93ed572 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 6, 2020
@petermetz
fix(common): servers.startOnPort() error handling
31f98f4 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 12, 2020
@petermetz
fix(common): servers.startOnPort() error handling
d7bcaf9 
Promise no longer hangs if error event is fired on the server object

Fixes hyperledger-cacti#317

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@petermetz