Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish v2.0.0-rc.3 #3427

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore(release): publish v2.0.0-rc.3 #3427

merged 1 commit into from
Jul 24, 2024

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sandeepnRES sandeepnRES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one change required.
Also the CI tests are failing (because of some outdated module in cordapp) which @VRamakrishna has fixed in his PR, so if you wish you can bypass branch protections.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@sandeepnRES sandeepnRES merged commit 1ce7c60 into main Jul 24, 2024
142 of 144 checks passed
@sandeepnRES sandeepnRES deleted the release-v2.0.0-rc.3 branch July 24, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants