From 190237844e545b0c55f3367003f2c5e261e2714b Mon Sep 17 00:00:00 2001 From: "stefan.pingel@consensys.net" Date: Thu, 10 Oct 2024 15:32:00 +1000 Subject: [PATCH] don't do too much work when disabled Signed-off-by: stefan.pingel@consensys.net --- .../NewPooledTransactionHashesMessageHandler.java | 8 ++++---- .../eth/transactions/TransactionsMessageHandler.java | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageHandler.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageHandler.java index ab909eada13..f2e9378fd4b 100644 --- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageHandler.java +++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageHandler.java @@ -45,11 +45,11 @@ public NewPooledTransactionHashesMessageHandler( @Override public void exec(final EthMessage message) { - final Capability capability = message.getPeer().getConnection().capability(EthProtocol.NAME); - final NewPooledTransactionHashesMessage transactionsMessage = - NewPooledTransactionHashesMessage.readFrom(message.getData(), capability); - final Instant startedAt = now(); if (isEnabled.get()) { + final Capability capability = message.getPeer().getConnection().capability(EthProtocol.NAME); + final NewPooledTransactionHashesMessage transactionsMessage = + NewPooledTransactionHashesMessage.readFrom(message.getData(), capability); + final Instant startedAt = now(); scheduler.scheduleTxWorkerTask( () -> transactionsMessageProcessor.processNewPooledTransactionHashesMessage( diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsMessageHandler.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsMessageHandler.java index 3160d1a9c58..b6bbf442dab 100644 --- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsMessageHandler.java +++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsMessageHandler.java @@ -43,9 +43,10 @@ public TransactionsMessageHandler( @Override public void exec(final EthMessage message) { - final TransactionsMessage transactionsMessage = TransactionsMessage.readFrom(message.getData()); - final Instant startedAt = now(); if (isEnabled.get()) { + final TransactionsMessage transactionsMessage = + TransactionsMessage.readFrom(message.getData()); + final Instant startedAt = now(); scheduler.scheduleTxWorkerTask( () -> transactionsMessageProcessor.processTransactionsMessage(