feat(credentials): added credential sendProblemReport method #906
Conversation
Signed-off-by: Pavel Zarecky <zarecky@procivis.ch>
Signed-off-by: Pavel Zarecky <zarecky@procivis.ch>
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
==========================================
- Coverage 87.65% 87.57% -0.08%
==========================================
Files 470 470
Lines 11172 11189 +17
Branches 1868 1869 +1
==========================================
+ Hits 9793 9799 +6
- Misses 1313 1323 +10
- Partials 66 67 +1
Continue to review full report at Codecov.
|
| @@ -67,6 +67,7 @@ export interface CredentialsModule<CFs extends CredentialFormat[], CSs extends C | |||
|
|
|||
| // Credential | |||
| acceptCredential(options: AcceptCredentialOptions): Promise<CredentialExchangeRecord> | |||
| sendProblemReport(credentialRecordId: string, message: string): Promise<CredentialExchangeRecord> | |||
There was a problem hiding this comment.
Maybe we can also make this an object like we do with the other methods that contain both the credentialRecordId and message? Mainly for two reasons:
- Consistency with other methods
- It would allow to add more options in the future without needing to make a breaking change (we'll probably want to make it an options object when adding more options)
There was a problem hiding this comment.
@TimoGlastra refactored
| @@ -84,6 +84,9 @@ export abstract class CredentialService<CFs extends CredentialFormat[] = Credent | |||
| // methods for ack | |||
| abstract processAck(messageContext: InboundMessageContext<AgentMessage>): Promise<CredentialExchangeRecord> | |||
|
|
|||
| // methods for problem-report | |||
| abstract createProblemReport(message: string): ProblemReportMessage | |||
There was a problem hiding this comment.
Same here, if we make it an object it would be easier to add new properties later on (such as exposing the code)
Signed-off-by: Pavel Zarecky <zarecky@procivis.ch>
|
@Iskander508 I'll merge this once #908 is merged |
Signed-off-by: Pavel Zarecky zarecky@procivis.ch
Adding a convenience method to send problem report as part of RFC's 0036 and 0453 unhappy flow.
It is a complementary implementation to the
agent.proofs.sendProblemReport. But for credentials it was still missing.