Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add BBS context to DidDoc #789

Merged
merged 3 commits into from
May 24, 2022

Conversation

karimStekelenburg
Copy link
Contributor

BBS context was missing in the DidDocumentBuilder, resulting in some value being dropped during frameing. This PR adds the context.

Signed-off-by: Karim karim@animo.id

Signed-off-by: Karim <karim@animo.id>
@karimStekelenburg karimStekelenburg requested a review from a team as a code owner May 23, 2022 12:09
Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if it is really needed, but some tests might be nice (could be included in the other PR)

@karimStekelenburg karimStekelenburg enabled auto-merge (squash) May 23, 2022 12:23
Signed-off-by: Karim <karim@animo.id>
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #789 (1b82c63) into main (1c74618) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         435      435           
  Lines       10670    10670           
  Branches     1891     1891           
=======================================
  Hits         9340     9340           
  Misses       1268     1268           
  Partials       62       62           
Impacted Files Coverage Δ
...ges/core/src/modules/dids/domain/keyDidDocument.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c74618...1b82c63. Read the comment docs.

@karimStekelenburg karimStekelenburg merged commit c8ca091 into openwallet-foundation:main May 24, 2022
@karimStekelenburg karimStekelenburg deleted the fix/bbs-contexts branch May 24, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants