fix(anoncreds): wrong key name for predicates in proof object #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Jul 21, 2023
|
There are some errors with the type checking |
auto-merge was automatically disabled
July 26, 2023 14:15
Head branch was pushed to by a user without write access
Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Ry Jones <ry@linux.com> Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
fix/proof-predicate-key-name
branch
from
98fc8ed
to
71c430b
Compare
genaris
previously requested changes
Jul 26, 2023
| @@ -19,6 +19,7 @@ jobs: | |||
| with: | |||
| # pulls all commits (needed for lerna to correctly version) | |||
| fetch-depth: 0 | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
I think this change should be reverted from this PR
There was a problem hiding this comment.
i removed it sorry
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1517 +/- ##
===========================================
+ Coverage 62.83% 85.84% +23.00%
===========================================
Files 778 948 +170
Lines 17969 22627 +4658
Branches 3082 3957 +875
===========================================
+ Hits 11291 19424 +8133
+ Misses 6138 3021 -3117
+ Partials 540 182 -358
|
TimoGlastra
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.