Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(askar): in memory wallet creation #1498

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 5, 2023

Quick fix to allow the creation of an in-memory wallet (for test purposes). Previously, the parameter was supported but, due to a particular error thrown by @hyperledger/askar-shared it was not working.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner July 5, 2023 22:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #1498 (c026f7d) into main (04a8058) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
+ Coverage   85.79%   85.83%   +0.03%     
==========================================
  Files         943      943              
  Lines       22588    22608      +20     
  Branches     3915     3919       +4     
==========================================
+ Hits        19380    19406      +26     
+ Misses       3027     3021       -6     
  Partials      181      181              
Impacted Files Coverage Δ
packages/askar/src/wallet/AskarWallet.ts 66.35% <100.00%> (+0.31%) ⬆️
packages/askar/tests/helpers.ts 97.61% <100.00%> (+1.61%) ⬆️

... and 4 files with indirect coverage changes

@TimoGlastra TimoGlastra merged commit 4a158e6 into openwallet-foundation:main Jul 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants