Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify inbound transport through environment variable #1330

Closed
dbluhm opened this issue Jul 22, 2021 · 4 comments · Fixed by #1715
Closed

Cannot specify inbound transport through environment variable #1330

dbluhm opened this issue Jul 22, 2021 · 4 comments · Fixed by #1715
Assignees

Comments

@dbluhm
Copy link
Member

dbluhm commented Jul 22, 2021

At present, I don't think it is possible to specify --inbound-transport through the accompanying environment variable ACAPY_INBOUND_TRANSPORT. This stems from this argument being both an "append" and "nargs > 1" argument. The ConfigArgParse library does not accept a list of lists at the current version in use by ACA-Py or in the most recent release (1.5.1 at the time of writing).

I have a PR to ConfigArgParse that should address this: bw2/ConfigArgParse#240

Until my or another fix is merged and released, I figured it made sense to call out this limitation here.

If my assessment is off, I'd be happy to hear how you did it as all permutations I attempted and time spent examining the code seems to indicate this is just broken in ConfigArgParse lol.

@dbluhm
Copy link
Member Author

dbluhm commented Aug 6, 2021

My PR has been merged so this is now just awaiting a release with the fix.

@dbluhm dbluhm self-assigned this Dec 6, 2021
@MonolithicMonk
Copy link
Contributor

My PR has been merged so this is now just awaiting a release with the fix.

Were you ever able to configure this to work via environment variable like:
ACAPY_INBOUND_TRANSPORT: '[["http"], ["0.0.0.0"], ["8225"]]'

Interestingly, It works perfectly using an argument file which is also a yaml file but with inbound-transport flag

@ianco
Copy link
Member

ianco commented Apr 4, 2022

It should work, see this PR: #1627

@MonolithicMonk
Copy link
Contributor

No that doesn't work either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants