style: 2021-09-20 linter warnings batch 17 / 26; part 4

[Leeyoungone]

This is the UPDATED list of linter warnings that are avaliable as of 06-21-22! @alec-p-hong

Description

-- Issue #2093 had weird numbering (I messed up in the process) so there's also a linter warning with an ID of 41 🤪 sorrryyyyy

As of today (21s of September, 2022) I have sectioned off issue #1366 into chunks of "10" based on the IDs that the linters were originally given. I've gone through them and have sectioned it off by 1 - 10 but some linter warnings from the orignal issue (ex. linter warning 28), do not exist so not all the PRs will have 10 linter warnings at a time.

From the original issue:

For example if an issue has 1 / 26 in it's title, that's batch number one, meaning that the linter warnings that needs to be fixed in the scope of that task are the ones with IDs of 1 to 10, inclusive, as in 1,2,3,4,5,6,7,8,9,10.
For 2 / 26 in the title, that's batch #2 and the corresponding warnings IDs in the main table are therefore: 11,12,13,14,15,16,17,18,19,20.
For 3 / 26 in the title, that's batch #3 you get the point...

Acceptance Criteria

1. Each linter warning is either fixed or a specific new issue is created aimed at exactly that one linter warning where applicable: If fixing a linter warning requires a larger refactoring of the codebase, then it is justifiable to break it out into it's own GH task.
2. The pull request submitted links to all (if any) additional issues that were created for the linter warnings that did not fit in the scope of the issue.

Full List of Linter Warnings

Important: Do not fix all of these, just a subset of them as per the guidelines in the Description section above. Otherwise your pull request might get rejected due to unfixable conflicts.

ID	Description
41	./packages/cactus-cmd-api-server/src/main/typescript/config/config-service.ts: line 497, col 26, Warning - Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
42	./packages/cactus-cmd-api-server/src/main/typescript/config/config-service.ts: line 592, col 42, Warning - Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
43	./packages/cactus-cmd-api-server/src/main/typescript/config/convict-plugin-array-format.ts: line 3, col 25, Warning - Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)
44	./packages/cactus-cmd-api-server/src/main/typescript/config/convict-plugin-array-format.ts: line 3, col 35, Warning - Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
45	./packages/cactus-cmd-api-server/src/main/typescript/config/convict-plugin-array-format.ts: line 3, col 42, Warning - Argument 'schema' should be typed with a non-any type. (@typescript-eslint/explicit-module-boundary-types)
46	./packages/cactus-cmd-api-server/src/main/typescript/config/convict-plugin-array-format.ts: line 3, col 51, Warning - Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
47	./packages/cactus-cmd-api-server/src/main/typescript/config/convict-plugin-array-format.ts: line 13, col 23, Warning - Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)
48	./packages/cactus-cmd-api-server/src/test/typescript/fixtures/plugin-ledger-connector-stub/web-services/deploy-contract-endpoint.ts: line 46, col 3, Warning - Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)
49	./packages/cactus-cmd-api-server/src/test/typescript/fixtures/plugin-ledger-connector-stub/web-services/run-transaction-endpoint.ts: line 44, col 3, Warning - Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)
50	./packages/cactus-cmd-api-server/src/test/typescript/fixtures/plugin-ledger-connector-stub/web-services/unprotected-action-endpoint.ts: line 49, col 3, Warning - Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

[yixin0829]

Hi @Leeyoungone, me and a few of my friends would like to help out on this issue. Can we fork it and contribute as a team on the fork then later create a patch to merge back?

[alec-p-hong]

Hi @yixin0829, this is Alec. I believe that most of these updated linter warnings should have been resolved or leave-as-is based on the maintainer on the project. If you need to find more linter warnings, please refer to #1366 and ask a maintainer to give you an updated list of the linter warnings.

[petermetz]

Closing due to the linter numbers having gone stale in the meantime.
We need to invent a better way of tracking linter warnings for future issues like this that we'll open because the line numbers are ephemeral and therefore not well suited for this.

Please see these if you'd still like to work on linter warnings that are beginner-friendly:
https://github.com/hyperledger/cacti/issues/2674
https://github.com/hyperledger/cacti/issues/2675