Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate update-agent-configs.ts with the CLI command for generating agent configs #3921

Open
Tracked by #3552
tkporter opened this issue Jun 6, 2024 · 0 comments

Comments

@tkporter
Copy link
Collaborator

tkporter commented Jun 6, 2024

Problem

Blocked by #3720

See here for full context and design: https://www.notion.so/hyperlanexyz/Hybrid-HaaS-67195982e71b42de92bc83038498583a?pvs=4#a3831e1497b249028ae6bca6a70994a1

Atm, agent config generation lives in a few different places and is used in a few different ways - we should consolidate this, and make sure that we're able to generate agent configs easily from the registry.

Solution

  • Migrate infra's update-agent-config.ts to the CLI command from Add a CLI command to generate an agent config from registry content #3720
  • Ensure feature parity with update-agent-config.ts the CLI command from Add a CLI command to generate an agent config from registry content #3720. It should be possible to run this script with a flag indicating whether the generated agent config should contain all mainnets or testnets.
  • Some transaction overrides will continue to exist in infra. For our CI pipeline, we will pipe in the transaction overrides to the CLI command as config. This way we continue to include these transaction overrides in the agent config that’s shipped in agent JSONs. This is kind of blocked on https://github.com/hyperlane-xyz/issues/issues/1169
  • The CI check to ensure agent configs are up to date and accurate should be updated to use this CLI command. The mainnet_config.json would include all mainnet chains found in the main branch of the registry, and the testnet_config.json would include all testnet chains found in the main branch of the registry
  • Note at the moment the gRPC URLs in the registry lack http:// or https://, which are required by the agents. We should figure out a consolidation plan for this
  • Similar for transactionOverrides - this differs from the gasPrice.amount and gasPrice.denom expected by the agents for cosmos chains. It's probably easiest to just change the registry schema to allow cosmos gas prices to be added - either in the same schema that the agents use today, or to change the schema to something that registry ppl like more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant