Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike using fetch #1227

Open
6 of 8 tasks
sapiderman opened this issue Jan 5, 2024 · 2 comments
Open
6 of 8 tasks

Spike using fetch #1227

sapiderman opened this issue Jan 5, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sapiderman
Copy link
Contributor

sapiderman commented Jan 5, 2024

Spike using fetch vs Axios

  1. Fetch has native support
  2. Already stable in Node v21

Target

  1. Is it possible to use native Fetch and replace Axios
  2. How much work would it be
  3. Will node v21 breaking?

TODO

References

  1. https://blog.logrocket.com/fetch-api-node-js/
  2. https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Basic_concepts

Edit :

@sapiderman sapiderman added the enhancement New feature or request label Jan 5, 2024
@syamsudotdev syamsudotdev self-assigned this Jan 8, 2024
@sapiderman
Copy link
Contributor Author

@nrsysdev should we split the issue? 1 for fetch, 1 for node v21/22?

@syamsudotdev
Copy link
Contributor

@nrsysdev should we split the issue? 1 for fetch, 1 for node v21/22?

not necessarily needed. We can use node-fetch as it is compatible with fetch web API. Since Monika is using Node v18 (latest LTS). We can use this package until a new NodeJS LTS version has stable fetch API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants