RPC Name Conflict with Client Generated Code

[SkamDart]

Bug Report

Version

└── tonic v0.5.2
└── tonic-build v0.5.2

Platform

Linux chowder 5.11.0-27-generic #29~20.04.1-Ubuntu SMP Wed Aug 11 15:58:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Crates

tonic-build

Description

Service name connect creates conflict with generated client connect function.

Sample proto

syntax = "proto3";

package request;

message ConnectRequest {}

message ConnectResponse {}

service Connector {
    rpc Connect(ConnectRequest) returns (ConnectResponse) {}
}

Full repro

A fix might be to check the generated service definitions for reserved identifiers like tokio/prost does.

[LucioFranco]

To work around this you should be able to just disable the transport feature of tonic-build.

[chancila]

@LucioFranco isn't it more desirable to just fix the issue instead of using this workaround? what's the reservation for #749 or just generally fixing this?