Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a message max size #264 not fixed #735

Closed
ghost opened this issue Aug 7, 2021 · 1 comment
Closed

Allow setting a message max size #264 not fixed #735

ghost opened this issue Aug 7, 2021 · 1 comment
Labels
A-tonic C-bug Category: Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 7, 2021

Bug Report

When sending large messages, does not work even though this issue was said to be fixed #264.

image

Version

tonic 0.5
tonic_build 0.5.1
prost 0.8

Platform

Windows 10

Description

Send large a message from GRPC serve. Set the max_frame_size as mention here - #264.

image

Consume endpoint using BloomRPC client. I expect a successful response instead of an error.

Not complaining but I am tired of finding bugs or issues in open source code. I get slowed down so much. This is a lesson to stick with std.lib/1.0.0+ libs or accept situations like this.

Alternative solutions

I could stream my response instead.

@LucioFranco LucioFranco added this to the 0.6 milestone Oct 13, 2021
@LucioFranco LucioFranco added A-tonic C-bug Category: Something isn't working labels Oct 13, 2021
@LucioFranco LucioFranco modified the milestones: 0.6, 0.7 Oct 20, 2021
@LucioFranco
Copy link
Member

Are you sure this error is coming from tonic? I don't see anywhere where we might have created this error message?

@LucioFranco LucioFranco removed this from the 0.7 milestone Feb 22, 2022
@LucioFranco LucioFranco closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tonic C-bug Category: Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant