feat(tonic): add Request and Response extensions
#642
Conversation
davidpdrsn
force-pushed
the
david/extensions
branch
from
b937f78
to
9df7394
Compare
davidpdrsn
changed the title
Request extensionsRequest and Response extensions
Adds `tonic::Extensions` which is a newtype around `http::Extensions`. Request extensions can be set by interceptors with `Request::extensions_mut` and retrieved from RPCs with `Request::extensions`. Extensions can also be set in tower middleware and will be carried through to the RPC. Since response extensions cannot be set by interceptors the main use case is to set them in RPCs and retrieve them in tower middlewares. Figured that might be useful. Fixes #255
davidpdrsn
force-pushed
the
david/extensions
branch
from
9df7394
to
afcb662
Compare
|
|
||
| match client.unary_call(Input {}).await { | ||
| Ok(_) => {} | ||
| Err(status) => panic!("{}", status.message()), |
There was a problem hiding this comment.
wouldn't an unwrap here work?
There was a problem hiding this comment.
Yeah true. I copied some other test that didn't have it. Will fix it.
| inner: S, | ||
| } | ||
|
|
||
| impl<S> Service<HyperRequest<Body>> for InterceptedService<S> |
There was a problem hiding this comment.
Its crazy how complex this is :(
There was a problem hiding this comment.
Yeah I really wanna try and find a way to make this easier. Having to implement NamedService also complicates things a bit because you cannot take a middleware from tower and use it with tonics router.
There was a problem hiding this comment.
Yeah, though I don't have a proper solution either :(
tonic/src/extensions.rs
Outdated
| /// | ||
| /// [`Interceptor`]: crate::Interceptor | ||
| /// [`Request`]: crate::Request | ||
| pub struct Extensions(http::Extensions); |
There was a problem hiding this comment.
nit (not blocking): Should we make this a proper struct with an inner? Idk what style I like better honestly but I tend to do that over a tuple struct 🤷 up to you doesn't matter too much.
There was a problem hiding this comment.
I don't really have a preference. I'll change it.
| @@ -62,6 +62,7 @@ | |||
| //! [`transport`]: transport/index.html | |||
|
|
|||
| #![recursion_limit = "256"] | |||
| #![allow(clippy::inconsistent_struct_constructor)] | |||
There was a problem hiding this comment.
The most pedantic lint ever https://rust-lang.github.io/rust-clippy/master/#inconsistent_struct_constructor. rust-analyzer was complaining about it.
Adds
tonic::Extensionswhich is a newtype aroundhttp::Extensions.Request extensions can be set by interceptors with
Request::extensions_mutand retrieved from RPCs withRequest::extensions. Extensions can also be set in tower middlewareand will be carried through to the RPC.
Since response extensions cannot be set by interceptors the main use
case is to set them in RPCs and retrieve them in tower middlewares.
Figured that might be useful.
Fixes #255