Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthService isn't public #409

Closed
xd009642 opened this issue Jul 23, 2020 · 3 comments
Closed

HealthService isn't public #409

xd009642 opened this issue Jul 23, 2020 · 3 comments
Labels
A-health E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@xd009642
Copy link
Contributor

Feature Request

As discussed on discord I'm attempting to route between two grpc services (one being the health service) and a http service. However, I've found I can't use the HealthService directly because it's not public https://github.com/hyperium/tonic/blob/master/tonic-health/src/server.rs#L108

Crates

tonic-health

@xd009642
Copy link
Contributor Author

Just making the struct pub isn't enough you'd also have to rework a bit of the API. I've done this locally and if it ends up being desired as a feature I can start a PR - I've not pushed anything yet because it's not currently working

@xd009642
Copy link
Contributor Author

This may be unnecessary, if #410 is solved this will be solved via that or this is unnecessary

@LucioFranco LucioFranco added A-health E-help-wanted Call for participation: Help is requested to fix this issue. labels Jul 23, 2020
@alce
Copy link
Collaborator

alce commented Sep 20, 2020

Resolved via #419.

@alce alce closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-health E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

No branches or pull requests

3 participants