Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doc(hidden) on impl Service? #344

Closed
l4l opened this issue May 7, 2020 · 1 comment · Fixed by #347
Closed

Why doc(hidden) on impl Service? #344

l4l opened this issue May 7, 2020 · 1 comment · Fixed by #347
Labels
A-build C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@l4l
Copy link
Contributor

l4l commented May 7, 2020

It seems that service is generated with doc(hidden) attribute (introduced in cd9133a):

#[doc(hidden)]
pub struct #server_service<T: #server_trait> {
inner: _Inner<T>,
}

This type is intended for direct using, e.g. in helloworld:

.add_service(GreeterServer::new(greeter))

It seems that @carllerche also had this question: #1 (comment), but it left without answer.

@LucioFranco
Copy link
Member

Uh good question, we should probably remove that :) I'd totally accept a PR for this I have limited time atm.

@LucioFranco LucioFranco added C-bug Category: Something isn't working A-build E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants