Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.proto files are licensed under Apache-2.0 #1939

Open
LecrisUT opened this issue Sep 13, 2024 · 1 comment · May be fixed by #1942
Open

.proto files are licensed under Apache-2.0 #1939

LecrisUT opened this issue Sep 13, 2024 · 1 comment · May be fixed by #1942

Comments

@LecrisUT
Copy link

The main project is licensed under MIT, but it seems to contain Apache-2.0 licensed files as well. Shouldn't the Cargo.toml file reflect that?

Additionally the generated files like types.bin have embedded BSD-3-Clause license text.

@LecrisUT
Copy link
Author

I received some advice from fellow fedora rust packagers about packaging these crates. The main suggestion is to move codegen to a build.rs in each relevant crate. There isn't a circular dependency that would block this, and this would guarantee that the generated files are always up-to-date. The main concern is about types.bin being rather obscure, and on Fedora side we should be re-generating the code, which would be difficult if these are in the workspace. Would that be ok with you?

Another uncertain question we have is with the inclusion of BSD-3-Clause license which seems to be from protobuf files, and we are not sure if the license in Cargo.toml should reflect the source code or the artifacts. At the very least though, the Apache-2.0 license need to be included

@LecrisUT LecrisUT linked a pull request Sep 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant