feat(types): Add gRPC Richer Error Model support (RetryInfo) #1095
Conversation
Start using `mod.rs` filenames. This makes the style more consistent across crates.
Add the code related to richer error model support to a new `richer_error` module. This improves readability and hopefully will make it easier to add new features to `tonic-types` in the future.
Following implementation at flemosr/tonic-richer-error.
|
Oh somehow this totally fell off my radar let me review this on monday! sorry about the delay. |
tonic-types/src/richer_error/mod.rs
Outdated
| details, | ||
| }; | ||
|
|
||
| Bytes::from(status.encode_to_vec()) |
There was a problem hiding this comment.
Why encode to vec instead of using BytesMut + BufMut and regular encode? So that we avoid the vec round trip?
There was a problem hiding this comment.
Using BytesMut indeed makes much more sense, thanks! It seems to me that using BufMut is not necessary in this case but I may be missing something.
tonic-types/src/richer_error/mod.rs
Outdated
|
|
||
| /// Used to implement associated functions and methods on `tonic::Status`, that | ||
| /// allow the addition and extraction of standard error details. | ||
| pub trait StatusExt { |
There was a problem hiding this comment.
We probably want to seal this trait similar to https://docs.rs/tower-http/latest/src/tower_http/builder.rs.html#45 that way outside users can't implement it and we can add more required fn as we please without making a breaking change.
There was a problem hiding this comment.
You are right. I did not know this pattern, quite useful. Thanks!
| use super::super::pb; | ||
| use super::super::{FromAny, IntoAny}; |
There was a problem hiding this comment.
Nit: I like combining these since they have a similar path.
There was a problem hiding this comment.
I missed that, thanks!
Adjustments following suggestions by @LucioFranco in hyperium#1095. Improve `gen_details_bytes`, seal `StatusExt`, adjust imports style.
|
No problem! Hopefully I addressed all comments but please let me know if you think we should make any further changes. |
Motivation
The gRPC Richer Error Model is quite useful to send additional feedback to clients, and is supported by many gRPC libraries in other languages.
Solution
This PR continues the work initiated at #1068. It improves the organization of
tonic-typesmodules, and adds support for theRetryInfostandard error message type to that crate.