You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The example in the docs for http1::Builder uses header_read_timeout without timer. It's not meant as complete running code, but still, it's weird that if you did try to use it, you'd panic.
The example Timer implementation for Tokio is a working example. The module is private, but we're exposing hyper::rt::{Sleep, Timer}here, which is what you'd need to implement this.
I agree with all of that. I think the three points all still stand, as opportunities for improvement. Will eventually give it a shot if nobody beats me to it.
Three mini-issues here:
Documentation for
.header_read_timeout()
doesn't mention that it requires.timer()
or it'll panic.The example in the docs for
http1::Builder
usesheader_read_timeout
withouttimer
. It's not meant as complete running code, but still, it's weird that if you did try to use it, you'd panic.No pointer to an implementation of Timer for tokio. I found a full implementation in a doc-comment, but unfortunately that's a private module.
The text was updated successfully, but these errors were encountered: