Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the MakeService stuff #2854

Closed
seanmonstar opened this issue May 20, 2022 · 1 comment
Closed

Remove the MakeService stuff #2854

seanmonstar opened this issue May 20, 2022 · 1 comment
Labels
A-docs Area: documentation. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

With the removal of the higher-level hyper::Server type, we no longer need the MakeService, MakeServiceRef, MakeServiceFn, etc. That stuff can exist in tower.
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-docs Area: documentation. C-feature Category: feature. This is adding a new feature. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
@oddgrd oddgrd mentioned this issue May 24, 2022
Merged
@seanmonstar
Copy link
Member Author

This was completed as part of #2932.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

No branches or pull requests
1 participant
@seanmonstar