Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML directory in config #10

Open
MaikNeubert opened this issue Sep 3, 2024 · 1 comment
Open

HTML directory in config #10

MaikNeubert opened this issue Sep 3, 2024 · 1 comment

Comments

@MaikNeubert
Copy link

Hello,

in the documentation the HTML config parameter is described as the "Path to the HTML file generated by the Swagger document generator"

But in the actual implementation it just returns the string set in the config and is not looking for the file to return.
Also setting the parameter "html" does not save the generated html inside of the configured file.

From HttpServer:
#https://github.com/hyperf/swagger/blob/master/src/HttpServer.php#L100

 protected function getHtml(): string
    {
        if (! empty($this->config['html'])) {
            return $this->config['html'];
        }

        return <<<'HTML'
       ...
       HTML;
       }

Do i miss something or is this just not correctly implemented yet?

Thanks and kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@MaikNeubert and others