Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark L and R on panning editor #948

Closed
Porrumentzio opened this issue Sep 30, 2020 · 12 comments
Closed

Mark L and R on panning editor #948

Porrumentzio opened this issue Sep 30, 2020 · 12 comments

Comments

@Porrumentzio
Copy link

Currently it is confusing because there is no way further than trying out to know which side is left and which right.

Indicating it with L and R would solve this problem

@trebmuh
Copy link
Member

trebmuh commented Sep 30, 2020

Not sure what window/space you're referring to. The only thing I can think of already displays a L/R:

hydro-pan

@Porrumentzio
Copy link
Author

Sorry for closing, it was a mistake.

The space I say is in the bottom side of the pattern editor, where the velocity, probability... of each note can be edited. And also the panoramization

@trebmuh
Copy link
Member

trebmuh commented Sep 30, 2020

OK, I see now.

(PS: please, put a screenshot next time.)

@Porrumentzio
Copy link
Author

Sorry, I was without a computer

@oddtime
Copy link
Contributor

oddtime commented Dec 10, 2020

screenshot-b95f1a3f
A message similar to this (appearing while changing note Pan) could be useful and easy to program

@oddtime
Copy link
Contributor

oddtime commented Dec 10, 2020

Opened pull request #1015 for the message

@Porrumentzio
Copy link
Author

Great! Nevertheless, still one has to try the panning for knowing if that was L or R. Would it be difficult to add those letters into each side (up and down) of the automation editor?

Something like this:
irudia

@oddtime
Copy link
Contributor

oddtime commented Dec 10, 2020

added R L in Pull Req. But they scroll

@theGreatWhiteShark
Copy link
Contributor

The note property display can use some scale in general. For velocity and probability having e.g. a 0, 0.5, and 1 wouldn't hurt either. For the lead and lag displaying the amount of milliseconds would be nice too.

@oddtime
Copy link
Contributor

oddtime commented Dec 19, 2020

For the lead and lag displaying the amount of milliseconds would be nice too.

Is it a fixed time value or depends on bpm?
From the current InfoMessage on the LCD it seems it has steps of 0.1 ticks so showing the scale in ms could be tricking

@theGreatWhiteShark
Copy link
Contributor

Is it a fixed time value or depends on bpm?
From the current InfoMessage on the LCD it seems it has steps of 0.1 ticks so showing the scale in ms could be tricking

It's given in ticks (probably multiplied by some constant) and depends on the bpm. So, you are right. Displaying milliseconds would require to redraw the widget when passing a tempo marker. This does not seem to be a good idea. Maybe using something like "fraction of a quarter" would be more appropriate instead.

@theGreatWhiteShark
Copy link
Contributor

Implemented in #1544. It does not added a "L" and "R" indicator as this did prove difficult/not working in this scrollable widget. But on all changes of the panning you get now a status message telling whether the note is panned to the left or right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants