Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support pg15 #75

Merged
merged 4 commits into from
May 5, 2023
Merged

[feature] support pg15 #75

merged 4 commits into from
May 5, 2023

Conversation

JerrySievert
Copy link
Contributor

This updates columnar and the build system to support postgresql 15.

What's changed?

  • updated columnar code to support the changes from postgres 15
  • added a mechanism to build the tests that are built by pg_regress in versions older than postgres 15 (https://www.postgresql.org/message-id/1655733.1639871614@sss.pgh.pa.us)
  • added alternate test results for postgres 15 output changes
  • updated spilo build for 15
  • updated the hash for parquet fdw

closes #53 and #59

JerrySievert and others added 4 commits May 2, 2023 12:12
* [columnar] Columnar vacuum

* Vacuum columnar tables by combining last n stripes until stripe row
  max count is reached. Vacuuming decision also include information
  about number of deleted rows of each stripe.
  If there is only one stripe, vacuum will be done if percentage of
  deleted rows is higher than 20%.

* Updated regression test to cover vacuum

* [columnar] Autovacuum for columnar tables

* Add pgstat for insert/delete/update table hooks so autovacuum process
  know if vacuum should be done.

---------

Co-authored-by: mkaruza <mkaruza@users.noreply.github.com>
@JerrySievert JerrySievert self-assigned this May 2, 2023
@wuputah
Copy link
Member

wuputah commented May 2, 2023

note that the upgrade test failure is expected due to hydra:15 not existing previously. once other reviews are done, I can merge (override the protection).

Copy link
Collaborator

@owenthereal owenthereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the upgrade test failure is expected due to hydra:15 not existing previously.

We could manually publish the hydra:15 image in this branch to ghcr.io as the baseline, and the upgrade acceptance test would test the upgrade to the same version, which should always pass.

We would need to set the max version to 15 for the columnar extension in splio: https://github.com/hydradatabase/hydra/blob/6784a2463294efd66d70c49bf438bcb533c03ec1/files/spilo/postgres-appliance/scripts/spilo_commons.py#L15. I think pg_ivm need to be whitelisted here as well.

Besides, Spilo has a new release. Does it worth upgrading to it?

Deferring the columnar 15 upgrade part to @mkaruza

@JerrySievert
Copy link
Contributor Author

I think pg_ivm need to be whitelisted here as well.

if we have agreement, I can make that change as part of this PR, but can also make the case that it might be worth a second PR.

Besides, Spilo has a new release. Does it worth upgrading to it?

maybe that should be part of a second PR if we decide to do it.

Copy link
Contributor

@mkaruza mkaruza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JerrySievert JerrySievert merged commit 07d233f into main May 5, 2023
@JerrySievert JerrySievert deleted the feature-support-pg15 branch May 5, 2023 14:48
@wuputah
Copy link
Member

wuputah commented May 5, 2023

We could manually publish the hydra:15 image in this branch to ghcr.io as the baseline, and the upgrade acceptance test would test the upgrade to the same version, which should always pass.

This needs to be done or the image will never get built, because it doesn't build unless the test pass. If you need assistance with doing this, please reach out to @owenthereal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pg15
4 participants