Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[columnar] Use class comparison operator for types which doesn't have one #184

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mkaruza
Copy link
Contributor

@mkaruza mkaruza commented Oct 27, 2023

  • If column type doesn't have comparison operator we are checking if class operator can be found. Use that operator for writing and reading chunks.
  • Fixed existing test to show feature functionality

* If column type doesn't have comparison operator we are checking if
  class operator can be found. Use that operator for writing and
  reading chunks.
@mkaruza mkaruza changed the title [columnar] Use family comparison operator for types which doesn't have one [columnar] Use class comparison operator for types which doesn't have one Oct 27, 2023
Copy link
Contributor

@JerrySievert JerrySievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wuputah wuputah merged commit 22d647e into main Oct 27, 2023
@wuputah wuputah deleted the github#178 branch October 27, 2023 18:16
@wuputah wuputah mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants