Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article Microdata uses wrong @id property #62

Closed
caendesilva opened this issue Apr 4, 2022 · 0 comments · Fixed by #81
Closed

Article Microdata uses wrong @id property #62

caendesilva opened this issue Apr 4, 2022 · 0 comments · Fixed by #81
Assignees

Comments

@caendesilva
Copy link
Member

caendesilva commented Apr 4, 2022

Describe the bug
The Article element for posts currently have the wrong ID format.

To Reproduce
Steps to reproduce the behavior:

  1. Run a compiled post through https://validator.schema.org/ to analyze the compiled data

Expected behavior
The current markup is <article id="post-article" , when it should be a unique ID to reference the actual post. For example, a post URI.

Current data:
image

Expected data:
image

Suggested implementation/fix
This is likely caused due to the Article styles being targeted using the #post-article. Replacing this with a CSS class would be better. Then we set the ID to posts/post-slug. If a site URL is set, we use that as a prefix, example: http://example.org/posts/post-slug

@caendesilva caendesilva self-assigned this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant