You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, This module seems to do everything the correct way but I wonder would it be more correct to also send the "Connection: Close" header to the client on the last inflight request before closing the socket? Otherwise we will end "Connection: Keep-Alive" back and the client will not be expecting the socket to close.
I think the client should always expect a socket to close (HTTP is a network protocol after all). Every keep-alive connection ends sooner or later. I don't think you're obligated to change to connection: close when you do (headers and payload may have already been sent before you decide to close for example). But that's just me. Is there any literature on the topic that implies that this is a good idea?
Hi, This module seems to do everything the correct way but I wonder would it be more correct to also send the "Connection: Close" header to the client on the last inflight request before closing the socket? Otherwise we will end "Connection: Keep-Alive" back and the client will not be expecting the socket to close.
i.e. the logic would go here: https://github.com/hunterloftis/stoppable/blob/master/lib/stoppable.js#L27
The text was updated successfully, but these errors were encountered: