Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border between rows in table flashes different color for a split second #381

Closed
AyushSehrawat opened this issue Oct 30, 2023 · 3 comments · Fixed by #400
Closed

Border between rows in table flashes different color for a split second #381

AyushSehrawat opened this issue Oct 30, 2023 · 3 comments · Fixed by #400
Labels
bug A confirmed report of unexpected behavior in the application contributions welcome Open to contributions

Comments

@AyushSehrawat
Copy link

Current Behavior

Whenever i change the theme to dark/light there is a white border flash for a split second in table component and then it changes to the normal one.

https://www.loom.com/share/5b8f2099222a4b88bdf8e5f9378a4633?sid=efdb20a3-9e38-4427-9ea3-4e912ea464f1

You can also try changing theme on this page and see it

https://www.shadcn-svelte.com/docs/components/data-table

Expected Behavior

No flash when changing theme

Steps To Reproduce

1.) Install table component and use it
2.) implement dark/light mode switcher and use it to see

Link to Reproduction / Stackblitz

https://www.shadcn-svelte.com/docs/components/data-table

More Information

No response

@AyushSehrawat AyushSehrawat added the bug A confirmed report of unexpected behavior in the application label Oct 30, 2023
@huntabyte huntabyte added the contributions welcome Open to contributions label Oct 31, 2023
@HubbeDev
Copy link
Contributor

HubbeDev commented Nov 3, 2023

@AyushSehrawat @huntabyte I think it have to do something with the transition-color class.
If you add transition-none to the table row the flashing is gone. I think their is a bigger problem here tho because that flashing behavour is not only on the table rows. Its on buttons and badges aswell. And probably more. I think it is on every element that have a transition-color on it.

Edit: I think the mode-watcher needs to implement so that all css transitions is temporarly disabled when chaning color scheme. I can open a issue on the mode-watcher for it.

@huntabyte
Copy link
Owner

Thanks for that info @HubbeDev! Was super simple to add into mode-watcher!

@AyushSehrawat
Copy link
Author

Thanks a lot for fixing @HubbeDev @huntabyte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed report of unexpected behavior in the application contributions welcome Open to contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants