Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PancakeV3 connector #195

Closed
fengtality opened this issue Sep 1, 2023 · 18 comments
Closed

PancakeV3 connector #195

fengtality opened this issue Sep 1, 2023 · 18 comments
Assignees
Labels

Comments

@fengtality
Copy link
Contributor

Description

  • Add connector to PancakeV3
  • Since Hummingbot already supports UniswapV3 and has a Uniswap V3 LP strattegy, the work is to replicate the UniswapV3 code architecture for PancakeV3 so that the UniswapV3 LP strategy works on PancakeSwap.

Bounty

@fengtality fengtality added bug Something isn't working pancakeswap connector bounty and removed bug Something isn't working labels Sep 1, 2023
@fengtality fengtality moved this to Assigned in Bounties Board Sep 1, 2023
@nikspz nikspz moved this from Assigned to Open in Bounties Board Sep 6, 2023
@nikspz
Copy link
Contributor

nikspz commented Sep 6, 2023

This bounty is re-OPENed right now. Ready for requests from developers wanted to be assigned .

@isreallee82
Copy link
Contributor

I will like to wok on this @nikspz

@michaelc9
Copy link

michaelc9 commented Oct 19, 2023

@fengtality @nikspz Is this still open for assignment? If yes, I'd like to take it on since I have been working on a PancakeV3 connector already.

@nikspz
Copy link
Contributor

nikspz commented Oct 19, 2023

@michaelc9 Yes, we still looking for the people with connector development experience

@alexeyneu
Copy link

so if i'll make pull request with this stuff you gonna pay, right?

@fengtality
Copy link
Contributor Author

so if i'll make pull request with this stuff you gonna pay, right?

There's an assignation process. See https://hummingbot.org/bounties/contributors/ for more info

@nikspz
Copy link
Contributor

nikspz commented Oct 20, 2023

Assigned to @michaelc9, please be informed:

  • Since you’re assigned to this bounty exclusively, please keep us informed on your progress over the next few days
  • Let us know if you don’t have time, and we will unassigned and keep it open for other devs
  • Only one dev can be assigned to one bounty

Thanks for your contribution!

@nikspz nikspz assigned fengtality and michaelc9 and unassigned fengtality Oct 20, 2023
@nikspz nikspz moved this from Open to Assigned in Bounties Board Oct 20, 2023
@nikspz
Copy link
Contributor

nikspz commented Oct 30, 2023

hi @michaelc9 Do you have updates about this bounty? please post it here

@nikspz
Copy link
Contributor

nikspz commented Nov 8, 2023

hi @michaelc9 Could you please answer if you working on this? Could you please submit draft PR?

@michaelc9
Copy link

hi @michaelc9 Could you please answer if you working on this? Could you please submit draft PR?

Yes, I will submit a draft PR by this week.

@michaelc9
Copy link

@nikspz I realized that the existing work I have is too tailored to LQS needs, and I would need to rewrite most of it to fit into gateway's current structure.
It will take much more time than I originally expected... perhaps it is better to reassign this bounty.

@nikspz nikspz moved this from Assigned to Open in Bounties Board Nov 13, 2023
@vic-en
Copy link
Collaborator

vic-en commented Nov 13, 2023

@nikspz I can take this.

@nikspz
Copy link
Contributor

nikspz commented Nov 13, 2023

Assigned to @vic-en, please be informed:

  • Since you’re assigned to this bounty exclusively, please keep us informed on your progress over the next week
  • Let us know if you don’t have time, and we will unassigned and keep it open for other devs
  • Only one dev can be assigned to one bounty

Thanks for your contribution!

@nikspz nikspz moved this from Open to Assigned in Bounties Board Nov 13, 2023
@nikspz
Copy link
Contributor

nikspz commented Nov 27, 2023

hi @vic-en Could you please kindly add your updates here?

@rapcmia rapcmia linked a pull request Nov 27, 2023 that will close this issue
2 tasks
@rapcmia rapcmia moved this from Assigned to Submitted in Bounties Board Nov 27, 2023
@vic-en
Copy link
Collaborator

vic-en commented Nov 27, 2023

@nikspz
WIP(#241):

  • Implementation done
  • Started performing manual test on each endpoint to ensure it all works.
  • Will finish up by writing some unit tests.

@nikspz
Copy link
Contributor

nikspz commented Nov 27, 2023

Very Nice

@rapcmia rapcmia removed a link to a pull request Dec 4, 2023
2 tasks
@nikspz
Copy link
Contributor

nikspz commented Dec 13, 2023

#247 Merged to the latest (gateway repo) development

@nikspz nikspz moved this from Submitted to Merged in Bounties Board Dec 13, 2023
@nikspz
Copy link
Contributor

nikspz commented Jan 16, 2024

Thanks for your participation, the bounty has been sent to @vic-en . The connector has been deployed on gateway development branch and hummingbot gateway version 1.23.0.

@nikspz nikspz closed this as completed Jan 16, 2024
@github-project-automation github-project-automation bot moved this from Merged to Assigned in Bounties Board Jan 16, 2024
@nikspz nikspz moved this from Assigned to Paid in Bounties Board Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Paid
Development

No branches or pull requests

6 participants