-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple DEX/Chain connector #103
Comments
Hey, Im the current developer for this connector, will post my current status shortly. |
Hi @mlguys good day to you |
Hey @rapcmia, I'm finishing the final component for the connector to be fully working on the gateway side. This component is the order tracking system which is used for tracking inflight or filled orders. Since Ripple SDK and the Ripple DEX doesn't support tracking filled orders, I had to make one in order to make the connector functional. ETA for PR with would be this weekend. It should implement |
hi @mlguys, Do you have any updates on this bounty, and about when can we review a PR? Thanks |
@nikspz, sorry for the delay, probably I will need one or two days more to push the PR. |
Hey @nikspz @rapcmia, sorry for the delay, I have added the PR. The connector can be considered as finished at this moment but since the test coverage is still low, I will add more tests in the upcoming days to bring it up. These upcoming tests will include a integration test where it will simulate trading operations on testnet, I hope this will demonstrate how the connector work. During the review, If you guys have question, feel free to ask! |
Thanks for your participation, the bounty has been sent to wallet suggested by @mlguys . The connector has been deployed on client/gateway development branch and client/gateway hummingbot version 1.23.0. |
Description
CLOBish
classBounty
The text was updated successfully, but these errors were encountered: