Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-scripts #37

Open
rmccue opened this issue Sep 6, 2018 · 6 comments
Open

Upgrade react-scripts #37

rmccue opened this issue Sep 6, 2018 · 6 comments

Comments

@rmccue
Copy link
Member

rmccue commented Sep 6, 2018

We're a bit behind here, so we should update, which should give us a bunch of fun stuff from newer react-scripts/webpack/etc.

@pdewouters
Copy link
Contributor

pdewouters commented Oct 8, 2018

To note that 2.* introduced chunked assets to the build process output. This makes it a bit tricky if the project expects to enqueue a singlebundle.js file.

@kadamwhite
Copy link
Collaborator

kadamwhite commented Oct 31, 2018

We can disable code-splitting if needed (see this GH thread) but I'll look into what might be needed to support it out of the box.

@josephfusco
Copy link

Would love to help make this happen. Is there any work already being done on this?

@kadamwhite
Copy link
Collaborator

kadamwhite commented Nov 26, 2018 via email

@josephfusco
Copy link

Just wanted to say I unfortunately have not had much time to work on this. If anyone else would like to work on this they are more than welcome to!

I was able disable code splitting using this solution however I am not sure that would suffice for this project. FYI there has also been some talk on restructuring asset-manifest.json generated from CRA2.

@roborourke
Copy link
Contributor

Hey all, I have a PR that works here: #42

No need to disable code-splitting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants