Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive checklists on frontend #15

Open
mattheu opened this issue Oct 14, 2017 · 16 comments · Fixed by #513
Open

Interactive checklists on frontend #15

mattheu opened this issue Oct 14, 2017 · 16 comments · Fixed by #513
Assignees
Labels
New Feature New major feature UX

Comments

@mattheu
Copy link
Member

mattheu commented Oct 14, 2017

Resolvable checklists just like github.

Read-only markdown checklists are supported as of #429 and able to be supported in the block editor via the todo-list-block plugin as of #513, but neither solution permits checking off items from the frontend.

@rmccue
Copy link
Member

rmccue commented Oct 18, 2017

This doesn't seem to be possible with marked, but if we switch our Markdown parser to https://github.com/markdown-it/markdown-it we can use https://github.com/revin/markdown-it-task-lists

@rmccue
Copy link
Member

rmccue commented Mar 12, 2018

  • Test
  • Check
  • Mixed
  • List
  • Extras

@rmccue rmccue self-assigned this Mar 12, 2018
@rmccue
Copy link
Member

rmccue commented Mar 12, 2018

Created https://github.com/humanmade/react-tasklist for the frontend interactions. Still need to do the following:

@rmccue
Copy link
Member

rmccue commented Mar 12, 2018

It looks like Interweave might be a good solution for the HTML parsing, and would solve it all at once. This uses the browser's DOM implementation rather than loading a massive external library, and we can add our custom components fairly easily.

@rmccue
Copy link
Member

rmccue commented Mar 12, 2018

Using Interweave is a little painful, but it could be worse. It doesn't let us match a whole element, only text, which seems like an oversight. That said, it'll be useful for @-mentions and similar if we want that (I do), so I'll see about giving it a try.

@jennybeaumont
Copy link

bump :)

@missjwo
Copy link
Member

missjwo commented Oct 16, 2019

+1 This would be super useful with the Google Doc CS EMEA Notepad in terms of adding a actionables section to the notepad and have it copy across as checkboxes.

https://docs.google.com/document/d/1m7GzNeoIIW8TGnLXyv7WfXIUpmmDnHHTS-fscZO68uk/edit#

@jennybeaumont
Copy link

Would love to see this get prioritized! Hugely useful for creating task lists/actionables for notes of all kinds. (JennyW just beat me to it, but this is a really really important feature), thnx!

@svandragt
Copy link

I guess the next natural improvement would be to assign those task by mentioning a person and then a task list, to make this work effectively. Just wondering if it's useful without that.

@jennybeaumont
Copy link

Agree that would be the natural next step. Still useful without it though as we can refer back to these lists for review. Helps with visibility and team accountability (if not with individual accountability).

@smckeown
Copy link

It would be really useful to get this up-and-running. As @jennybeaumont says it helps with accountability. Sumaiya and I have started having a regular People call and a list of actions at the end of a post lets us check in on where things are. See: https://operations.hmn.md/2020/01/20/people-call-notes-20-01-2020/

@rmccue
Copy link
Member

rmccue commented Jan 20, 2020

I'll try and get to this in the coming weeks; I invested a bunch of time into it and spun up a React component for it, but the integration turned out to be painful.

The main problem was tracking which list item was which in Markdown. However, I believe the Markdown parser we use might have been improved and provide a way to do this now (markedjs/marked#1440 and markedjs/marked#1430)

@rmccue
Copy link
Member

rmccue commented Jan 24, 2020

The main problem was tracking which list item was which in Markdown

As it turns out, this is still a problem. However, we can at least have read-only lists, where you have to edit the post manually; at least it will display task lists correctly.

Seems like a good compromise until we can work out some way to add editable items properly.

@rmccue
Copy link
Member

rmccue commented Feb 3, 2020

Read-only checklists are now deployed onto the HM network.

@jennybeaumont
Copy link

I would love to give this a new bump :)
The read-only checklists are a good start, but one blocker is the ability to add checklists from the admin (Gutenberg). Also, being able to check a checkbox without editing the post would be a huge plus.
(it's my birthday soon, just sayin)

@kadamwhite
Copy link
Contributor

Reopening because @jennybeaumont quite rightly pointed out that #513 still doesn't support frontend editing. I'll adjust the ticket to reflect the more narrow target scope

@kadamwhite kadamwhite changed the title Checklists Interactive checklists on frontend May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New major feature UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants