Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD upgrade to isort v5 #6681

Closed
MarcoGorelli opened this issue Aug 24, 2020 · 2 comments · Fixed by #6686
Closed

BUILD upgrade to isort v5 #6681

MarcoGorelli opened this issue Aug 24, 2020 · 2 comments · Fixed by #6686

Comments

@MarcoGorelli
Copy link

MarcoGorelli commented Aug 24, 2020 •
edited
Loading

The contributing guide says

Right now, we need an unreleased version of isort to avoid a bug:

However, it looks like the linked PR has been incorporated into the latest version of isort. I could submit a PR to address this if it would be welcome
@thomwolf
Copy link
Member

which linked PR are you referring to?

@MarcoGorelli
Copy link
Author

this one PyCQA/isort#1000 (it's linked to here https://huggingface.co/transformers/contributing.html )

@sgugger sgugger mentioned this issue Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update repo to isort v5 huggingface/transformers
2 participants
@thomwolf @MarcoGorelli