Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinov2 with REGISTERS #27379

Closed
2 tasks done
betterze opened this issue Nov 9, 2023 · 8 comments · Fixed by #35348 · May be fixed by #32127
Closed
2 tasks done

dinov2 with REGISTERS #27379

betterze opened this issue Nov 9, 2023 · 8 comments · Fixed by #35348 · May be fixed by #32127

Comments

@betterze
Copy link

betterze commented Nov 9, 2023

Model description

Dear huggingface team,

The fair team published an improved version of dinov2 VISION TRANSFORMERS NEED REGISTERS. The models and checkpoints are available in the dinov2 website, but not in hugging face.

Could you add this new model? I really appreciate your work.

Best Wishes,

Zongze

Open source status

  • The model implementation is available
  • The model weights are available

Provide useful links for the implementation


dinov2 reg checkpoint

@mhdirnjbr
Copy link

Hello! Could you kindly assign this task to me? I'm eager to take it on as my first contribution and greatly appreciate any guidance or considerations you can provide. Thank you in advance.

@betterze
Copy link
Author

betterze commented Nov 14, 2023

I am not a team member of hugging face, I can not 'assign the task to you'. But I believe you are very welcome to work on it, a lot of people will be benefited from your work. Thx

@mhdirnjbr
Copy link

mhdirnjbr commented Nov 14, 2023

Hello @amyeroberts @NielsRogge!
Can I please know your opinion about this endeavor? Thank you in advance.

@StarCycle
Copy link
Contributor

After reading the paper, I fully agree that DINOv2 with registers has better performance.

What's the current progress of this issue? @mhdirnjbr Did you submit a PR? I think timm has an implementation with registers

@amyeroberts
Copy link
Collaborator

@StarCycle @mhdirnjbr If any of you would like to, please feel free to open a PR to add this to the library!

@rvt123
Copy link

rvt123 commented May 18, 2024

Is Anyone working on this?

@NielsRogge
Copy link
Contributor

No. It's only 2 lines of code different compared to DINOv2 so feel free to take it up

@rvt123
Copy link

rvt123 commented May 18, 2024

Thanks for replying @NielsRogge, and I would take it up if I knew what I was doing. Maybe you could point me in the right direction I could give it a go.

Edit: I tried looking at both timm and Huggingface implementations but tbh I don't have a clue as to what's happening. If you do manage to take I would be grateful for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants