Skip to content

Commit

Permalink
Unpin fsspec (#5733)
Browse files Browse the repository at this point in the history
* Pass clobber True

* Unpin fsspec
  • Loading branch information
albertvillanova authored Apr 11, 2023
1 parent 2733929 commit f260793
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"importlib_metadata;python_version<'3.8'",
# to save datasets locally or on any filesystem
# minimum 2021.11.1 so that BlockSizeError is fixed: see https://github.com/fsspec/filesystem_spec/pull/830
"fsspec[http]>=2021.11.1,<2023.4.0", # Temporary pin
"fsspec[http]>=2021.11.1",
# for data streaming via http
"aiohttp",
# To get datasets from the Datasets Hub on huggingface.co
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/fsspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ def _strip_protocol(cls, path):
@pytest.fixture
def mock_fsspec():
original_registry = fsspec.registry.copy()
fsspec.register_implementation("mock", MockFileSystem)
fsspec.register_implementation("tmp", TmpDirFileSystem)
fsspec.register_implementation("mock", MockFileSystem, clobber=True)
fsspec.register_implementation("tmp", TmpDirFileSystem, clobber=True)
yield
fsspec.registry = original_registry

Expand Down
2 changes: 1 addition & 1 deletion tests/test_streaming_download_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _open(
@pytest.fixture
def mock_fsspec():
original_registry = fsspec.registry.copy()
fsspec.register_implementation("mock", DummyTestFS)
fsspec.register_implementation("mock", DummyTestFS, clobber=True)
yield
fsspec.registry = original_registry

Expand Down

0 comments on commit f260793

Please sign in to comment.