Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback mechanism for /parquet-and-dataset-info #804

Closed
lhoestq opened this issue Feb 10, 2023 · 2 comments
Closed

Rollback mechanism for /parquet-and-dataset-info #804

lhoestq opened this issue Feb 10, 2023 · 2 comments

Comments

@lhoestq
Copy link
Member

lhoestq commented Feb 10, 2023

This job creates parquet files in Hub repos. When the admin cancel endpoint is called, we need to rollback the revert the commits that were done in the repo.

One way to do it would be to add the job ID in the commit description, this way we can know which commits to revert.

Though it may require to patch datasets a little to do that

@lhoestq
Copy link
Member Author

lhoestq commented Feb 14, 2023

Actually I just noticed that we do only one commit to the repository, which makes the job almost atomic, and the case where we would need a rollback should be super rare.

I wouldn't prioritize it for now.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant