Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI worker tests are broken for gated datasets: ConnectionError #3025

Closed
albertvillanova opened this issue Aug 19, 2024 · 0 comments · Fixed by #3026
Closed

CI worker tests are broken for gated datasets: ConnectionError #3025

albertvillanova opened this issue Aug 19, 2024 · 0 comments · Fixed by #3026
Assignees
@albertvillanova
Labels
ci

Comments

@albertvillanova
Copy link
Member

albertvillanova commented Aug 19, 2024 •
edited
Loading

CI worker tests are broken for gated datasets: https://github.com/huggingface/dataset-viewer/actions/runs/10319430999/job/28567795990

FAILED tests/job_runners/config/test_split_names.py::test_compute_split_names_from_streaming_response[gated-False-SplitNamesFromStreamingError-DatasetNotFoundError] - AssertionError: assert 'ConnectionError' == 'DatasetNotFoundError'
  
  - DatasetNotFoundError
  + ConnectionError
FAILED tests/job_runners/dataset/test_config_names.py::test_compute_splits_response[gated-False-ConfigNamesError-DatasetNotFoundError] - AssertionError: assert 'ConnectionError' == 'DatasetNotFoundError'
  
  - DatasetNotFoundError
  + ConnectionError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertvillanova albertvillanova

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI worker tests for gated datasets huggingface/dataset-viewer
1 participant
@albertvillanova