Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib not installed in setup.py #74

Open
LWprogramming opened this issue Aug 31, 2023 · 2 comments · May be fixed by #75
Open

matplotlib not installed in setup.py #74

LWprogramming opened this issue Aug 31, 2023 · 2 comments · May be fixed by #75

Comments

@LWprogramming
Copy link

matplotlib exists in _deps but not in install_requires and extras is empty. Is this intentional? Had to install this by hand in my venv and was kinda surprised

@patrickvonplaten
Copy link
Contributor

Yeah that's probably a typo we could remove matplotlib from the deps list

@LWprogramming
Copy link
Author

Ah hmm, I just double-checked the codebase and it looks like it does need it in some files (not just wrapping a numpy call or something)

Checked the two and matplotlib is the only one in _deps that's missing so I'll just add it

@LWprogramming LWprogramming linked a pull request Aug 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants