Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web search option is not working properly. #1166

Closed
siddhantdante opened this issue May 24, 2024 · 7 comments
Closed

Web search option is not working properly. #1166

siddhantdante opened this issue May 24, 2024 · 7 comments

Comments

@siddhantdante
Copy link

image

@YWaller
Copy link

YWaller commented May 24, 2024

I also have this issue. These URLs worked yesterday, they do not work today. One url is a github.io the other is an aws link; it's not github or amazon's fault.

Using links specified in Assistant
Browsing search results
Failed to parse webpage
browserContext.newPage: Target page, context or browser has been closed,[link removed for clarity]

Failed to parse webpage
browserContext.newPage: Target page, context or browser has been closed,[link removed for clarity]

An error occurred

@YWaller
Copy link

YWaller commented May 24, 2024

I've been investigating a bit. This feature was working yesterday, but today it's broken.
If you go here:
https://github.com/huggingface/chat-ui/tree/main/src/lib/server/websearch

You'll see that an update was pushed yesterday #996. I don't find this to be a coincidence. I don't know much about playwright or anything, but from my search it seems the error is probably in one of these files:
https://github.com/huggingface/chat-ui/blame/102ff2d374d699d7a2e6163ca95adbe486ed1c30/src/lib/server/websearch/update.ts

https://github.com/huggingface/chat-ui/blob/102ff2d374d699d7a2e6163ca95adbe486ed1c30/src/lib/server/websearch/runWebSearch.ts

https://github.com/huggingface/chat-ui/blob/102ff2d374d699d7a2e6163ca95adbe486ed1c30/src/lib/server/websearch/search/search.ts

https://github.com/huggingface/chat-ui/blame/102ff2d374d699d7a2e6163ca95adbe486ed1c30/src/lib/server/websearch/scrape/playwright.ts

https://github.com/huggingface/chat-ui/blame/102ff2d374d699d7a2e6163ca95adbe486ed1c30/src/lib/server/websearch/scrape/scrape.ts

I'll keep digging, but I don't have the know-how to fix this, really. But hopefully narrowing it down to yesterday's update and these files helps whoever actually can. I don't think it's the timeout, since the "failed" message pops up instantly when you start a new chat and send a message.

@nsarrazin
Copy link
Collaborator

cc @Saghen who might know about this 👀

@Saghen
Copy link
Contributor

Saghen commented May 24, 2024

There was an issue with the playwright dependency after #996 which should have been resolved after #1161. If you're not running on docker, you may need to run npx playwright install

@YWaller
Copy link

YWaller commented May 24, 2024

Thanks for the replies/eyeballs on this one - I'm not running it locally or anything (no idea about the guy who made the issue); it's just huggingface.co/chat with an assistant. In my case, the assistant has a couple links it can look at, it seems the original poster's problem is with web search. Actually, if you pick any assistant on the list with any sort of web access, you get the same error, like this random one: https://huggingface.co/chat/conversation/6650d49e2682ff777fcefe93

@starlord263
Copy link

I am facing same on hugging chat online version.

@Saghen
Copy link
Contributor

Saghen commented May 25, 2024

Fixed in #1171

@Saghen Saghen closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants