Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plugin classes less environmental-variable focused, let users have an easier time just using torchrun, etc if they want #2973

Closed
muellerzr opened this issue Jul 29, 2024 · 0 comments · Fixed by #2998
Closed

Make plugin classes less environmental-variable focused, let users have an easier time just using torchrun, etc if they want #2973

muellerzr opened this issue Jul 29, 2024 · 0 comments · Fixed by #2998
Assignees
@muellerzr

Comments

@muellerzr
Copy link
Collaborator

muellerzr commented Jul 29, 2024 •
edited
Loading

E.g. just let the user do:

from accelerate import Accelerator
from accelerate.utils import FullyShardedDataParallelPlugin

plugin = FullyShardedDataParallelPlugin(...)
accelerator = Accelerator(fsdp_plugin=plugin)

(Currently we have much that needs to be set via environmental variables/accelerate config/accelerate launch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muellerzr muellerzr

Labels
None yet
Projects
Accelerate 1.0.0 Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make env variables optional for FSDP huggingface/accelerate
1 participant
@muellerzr