Replies: 1 comment
-
FWIW, I'm going with the second option -- we do not include |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The documentation for
file_path
arguments here says that file paths are relative to the hub'smodel-output
directory. When validating a model metadata file, I'm not sure what I should expect for thefile_path
:model-metadata
folder, e.g."model-metadata/hub-baseline.yml"
. This would allow me to check that it is correctly located inside of themodel-metadata
folder.model-output
from the file path for model output submissions, it seems like we should similarly removemodel-metadata
from the file path for model metadata submissions.Related question: maybe the idea is that the whole reason we know to call the validation functions for a model metadata or model output file is that it is located within that folder of the hub? So that actually, the check that a metadata file that's being validated is located inside of
model-metadata
is irrelevant, because we would only be validating it as a metadata file if it's in that folder? And any file that is in a submission that's not in eithermodel-output
ormodel-metadata
will just get a generic error thrown saying the file is not in an expected location?Beta Was this translation helpful? Give feedback.
All reactions